Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routes): reorder routes to override AMP pages #233

Merged
merged 2 commits into from Jan 24, 2021
Merged

Conversation

farnabaz
Copy link
Member

Move routes with /amp prefix to beginning of routes array

close #231

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #233 (e8b7a88) into master (9eb7fd3) will increase coverage by 1.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   67.02%   68.06%   +1.04%     
==========================================
  Files           5        5              
  Lines         188      191       +3     
  Branches       52       52              
==========================================
+ Hits          126      130       +4     
+ Misses         46       45       -1     
  Partials       16       16              
Impacted Files Coverage Δ
lib/module.js 67.70% <100.00%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb7fd3...e8b7a88. Read the comment docs.

@farnabaz farnabaz changed the title fix: reorder routes to serve correct pages fix(routes): reorder routes to serve correct pages Jan 24, 2021
@farnabaz farnabaz changed the title fix(routes): reorder routes to serve correct pages fix(routes): reorder routes to override AMP pages Jan 24, 2021
@farnabaz farnabaz merged commit a9c656d into master Jan 24, 2021
@farnabaz farnabaz deleted the order-routes branch January 24, 2021 16:10
@farnabaz farnabaz mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot serve manually an amp page from /amp folder
1 participant