Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: apolloProvider.prefetchAll in vue-apollo@3.0.0-beta.20 #156

Closed
nodegin opened this issue Sep 1, 2018 · 22 comments
Closed

TypeError: apolloProvider.prefetchAll in vue-apollo@3.0.0-beta.20 #156

nodegin opened this issue Sep 1, 2018 · 22 comments

Comments

@nodegin
Copy link

nodegin commented Sep 1, 2018

If I ran fresh npm install, vue-apollo@3.0.0-beta.20 will be installed.

When running the application, the app will die from TypeError: apolloProvider.prefetchAll is not a function

However npm i -S vue-apollo@3.0.0-beta.19 fixed this issue.

This question is available on Nuxt community (#c137)
@ghost ghost closed this as completed Sep 1, 2018
@ghost ghost added the cmty:question label Sep 1, 2018
@nodegin nodegin changed the title vue-apollo@3.0.0-beta.19 TypeError: apolloProvider.prefetchAll in vue-apollo@3.0.0-beta.20 Sep 1, 2018
@dohomi
Copy link
Contributor

dohomi commented Sep 1, 2018

true the .20 has breaking changes, I haven't had the time to target them

@dohomi dohomi reopened this Sep 1, 2018
@bjunc
Copy link
Contributor

bjunc commented Sep 1, 2018

Check out my issue from yesterday: https://cmty.app/nuxt/apollo-module/issues/c134

A quick fix is to use resolutions in your package.json file to explicitly reference beta.16 (non-breaking) until a new version of this module is released.

@dohomi my suggestion would be to nix the ^ since vue-apollo is technically in beta and breaking changes are excusable.

@dohomi
Copy link
Contributor

dohomi commented Sep 5, 2018

@bjunc @nodegin could you guys verify if the #158 is fixing your issue?

@Nainterceptor
Copy link

Hello,

npm i nuxt-community/apollo-module#vue-apollo-upgrade-beta-21
Seems to fix my error "apolloProvider.prefetchAll is not a function".

Thanks, I'll stick on this branch until this module release a new version, thanks

@nodegin
Copy link
Author

nodegin commented Sep 7, 2018

@dohomi I got it working now with npm i nuxt-community/apollo-module#vue-apollo-upgrade-beta-21 and vue-apollo@3.0.0-beta.20

However another error thrown on console:

TypeError: Cannot read property '$ssrContext' of undefined

In addition I am facing another issue now, in stable release (^4.0.0-rc1 and vue-apollo@3.0.0-beta.19), the onLogin token expire is not able to use, the cookie will always expire in past, but with latest update things looks normal except the console error message... Wishing the new update will come out soon

@nodegin
Copy link
Author

nodegin commented Sep 7, 2018

vue-apollo released beta.22 fixes this bug.

@nodegin nodegin closed this as completed Sep 7, 2018
@ishitatsuyuki
Copy link

Not fixed at all. Please reopen.

@nodegin nodegin reopened this Sep 9, 2018
@dohomi
Copy link
Contributor

dohomi commented Sep 10, 2018

@ishitatsuyuki I just updated the dependency in #158 can you check if this resolves your issue?

@PierrickP
Copy link

@dohomi working for me. Thanks

@nuxt-modules nuxt-modules deleted a comment Sep 10, 2018
@ghost ghost added cmty:bug-report and removed cmty:question labels Sep 10, 2018
@Atinux
Copy link
Contributor

Atinux commented Sep 10, 2018

I think you can update it and publish a new version @dohomi :)

@augustsaintfreytag
Copy link

Unfortunately, it seems "vue-apollo": "3.0.0-beta.25" has reintroduced the issue. I pinned the version by resolutions to fix the class-component issue (2 days ago, wasn't it?).

@dohomi
Copy link
Contributor

dohomi commented Sep 11, 2018

@ApricumMedia see my comments in #158
I'm not sure which version is suitable - I run the apollo-module rc1 and vue-apollo beta.19 at the moment

@AndrewBogdanovTSS
Copy link
Contributor

AndrewBogdanovTSS commented Sep 12, 2018

@dohomi why are you using ^ caret inside the versioning? Maybe it would be a better idea to remove that caret so all people that use your package could at least be sure that it won't break by itself by upgrading to newer versions of vue-apollo versions you don't support?
What I suggest is switch
"vue-apollo": "^3.0.0-beta.19"
to
"vue-apollo": "3.0.0-beta.19"
at least until the issue won't be resolved and properly tested

@dohomi
Copy link
Contributor

dohomi commented Sep 12, 2018

@AndrewBogdanovTSS the reason is first that there hasn't been any breaking change for the past 10 months while working with vue-apollo. I thought 3 days ago I could ship rc2 with the most current changes - now everything seems to be delayed with fixes. But yeah... you are right I'll release rc2 temporarily with beta.19 later the evening

@augustsaintfreytag
Copy link

@dohomi Despite all the nagging, your work on the module is still highly appreciated, Dominic — just wanted to leave you a thanks for that.

@dohomi
Copy link
Contributor

dohomi commented Sep 14, 2018

did I mention that rc2 is out? Hopefully rc3 will follow over the weekend.. I know that the naming convention is a bit off because this module relies on vue-apollo which by itself declares in beta. But for sure there will be stable releases coming up soon with less breaking changes and fiddling around

@AndrewBogdanovTSS
Copy link
Contributor

@dohomi any news about RC3 ?

@dohomi
Copy link
Contributor

dohomi commented Oct 6, 2018

rc3 is just published. It has still some issues with Nuxt v2, check out the newest issues. But for Nuxt 1.4.x everything is now updated to most recent versions of vue-apollo and the cli client

@dohomi dohomi closed this as completed Oct 6, 2018
@nodegin
Copy link
Author

nodegin commented Oct 7, 2018

@dohomi Still seeing some strange errors in console in rc3, but looks harmless to my application..

@dohomi
Copy link
Contributor

dohomi commented Oct 8, 2018

@nodegin which errors do you face?

@nodegin
Copy link
Author

nodegin commented Oct 8, 2018

@dohomi depends on which nuxt page, I have used head, asyncData methods

@blocka
Copy link

blocka commented Feb 28, 2019

What's the status with nuxt 2 support? I can't use resolutions since I'm using npm, not yarn, and just about every version I tried is installing beta.28 of vue-apollo, which seems to have this problem. Even if I manually install a different version of vue-apollo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants