Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): throw error if trying to set an undefined strategy #628

Merged
merged 1 commit into from
Apr 19, 2020
Merged

fix(core): throw error if trying to set an undefined strategy #628

merged 1 commit into from
Apr 19, 2020

Conversation

JoaoPedroAS51
Copy link
Collaborator

@JoaoPedroAS51 JoaoPedroAS51 commented Apr 19, 2020 •
edited
Loading

This error will be thrown if you try to set an undefined strategy. For example when using this.$auth.loginWith('my-undefined-strategy')

There are two cases:

  • If your strategy wasn't added to auth config.
  • If your strategy scheme wasn't found.

The current error:

bandicam 2020-04-19 14-37-59-851

With this fix:

bandicam 2020-04-19 14-38-03-771

@JoaoPedroAS51 JoaoPedroAS51 requested a review from pi0 April 19, 2020 17:40
@pi0 pi0 merged commit ab927f6 into dev Apr 19, 2020
@pi0 pi0 deleted the fix/throw-error-undefined-strategy branch April 19, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoaoPedroAS51 @pi0