-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add discord provider #914
feat: add discord provider #914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This is comprehensive, and I really appreciate you adding docs and to the demo.
Looks like CI is failing, there's some lint issues, and I've added a few questions.
…nto feat/discord-provider
any progress? |
When will this be merged? |
I currently just use my branch. |
@bmulholland Hi. can this PR be merged soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and for letting me know it's tried and tested. The prettier change doesn't belong in this PR, but it's good otherwise. Remove that and I'll merge.
@pinnouse @bmulholland Thank you <3 |
@lmf-git constructive criticism and help are welcome anytime. Entitlement and insults are not. |
@lmf-git trolls are not welcome here |
You're deleting comments because I'm saying that this module claims it can support Discord properly when it can't, it was a bad idea to include it and it should be removed because it isn't documented or supported properly. This is valid constructive criticism. If you cannot accept that make a private repo. |
Thanks for the message! This contains more information and is a bit more useful. However, it is still not actionable, is still rude, and frankly your messages have been unprofessional. Please file a bug report, which belongs as a separate issue, not as comments on a separate PR. Please ensure anything you write is polite. Contributions and fixes are also welcome, including for the docs. Also, consider that there may be something wrong with your setup, not with the module itself.
This is entitlement. If you don’t want to use this, you do not have to. |
Added parameter to src/utils/provider.ts:addAuthorize to send in use x-www-form-urlencoded and discord provider
Closes #804