Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add discord provider #914

Merged
merged 13 commits into from
Apr 8, 2021

Conversation

pinnouse
Copy link
Contributor

@pinnouse pinnouse commented Dec 9, 2020

Added parameter to src/utils/provider.ts:addAuthorize to send in use x-www-form-urlencoded and discord provider

Closes #804

@pinnouse pinnouse changed the title Add discord provider feat: add discord provider Dec 10, 2020
Copy link
Contributor

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is comprehensive, and I really appreciate you adding docs and to the demo.

Looks like CI is failing, there's some lint issues, and I've added a few questions.

package.json Outdated Show resolved Hide resolved
src/utils/provider.ts Outdated Show resolved Hide resolved
src/utils/provider.ts Outdated Show resolved Hide resolved
@satoufuyuki
Copy link

any progress?

@satoufuyuki
Copy link

When will this be merged?

@pinnouse
Copy link
Contributor Author

When will this be merged?

I currently just use my branch.
Not sure on the maintainers' stance on adding Discord support as provider - it adds some complications since Discord prefers to use forms instead of json for OAuth.

@qwexvf
Copy link

qwexvf commented Apr 8, 2021

@bmulholland Hi. can this PR be merged soon?
there are a few people using this code already and for me at least its pretty stable.

Copy link
Contributor

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience and for letting me know it's tried and tested. The prettier change doesn't belong in this PR, but it's good otherwise. Remove that and I'll merge.

.prettierrc Outdated Show resolved Hide resolved
@bmulholland bmulholland merged commit 5a3c3a8 into nuxt-community:dev Apr 8, 2021
@qwexvf
Copy link

qwexvf commented Apr 9, 2021

@pinnouse @bmulholland Thank you <3

@bmulholland
Copy link
Contributor

@lmf-git constructive criticism and help are welcome anytime. Entitlement and insults are not.

@nuxt-community nuxt-community deleted a comment from lmf-git Jun 14, 2021
@bmulholland
Copy link
Contributor

@lmf-git trolls are not welcome here

@nuxt-community nuxt-community deleted a comment from lmf-git Jun 14, 2021
@lmf-git
Copy link

lmf-git commented Jun 14, 2021

@lmf-git trolls are not welcome here

You're deleting comments because I'm saying that this module claims it can support Discord properly when it can't, it was a bad idea to include it and it should be removed because it isn't documented or supported properly.

This is valid constructive criticism. If you cannot accept that make a private repo.

@bmulholland
Copy link
Contributor

You're deleting comments because I'm saying that this module claims it can support Discord properly when it can't, it was a bad idea to include it and it should be removed because it isn't documented or supported properly.

Thanks for the message! This contains more information and is a bit more useful. However, it is still not actionable, is still rude, and frankly your messages have been unprofessional.

Please file a bug report, which belongs as a separate issue, not as comments on a separate PR. Please ensure anything you write is polite.

Contributions and fixes are also welcome, including for the docs.

Also, consider that there may be something wrong with your setup, not with the module itself.

This is valid constructive criticism. If you cannot accept that make a private repo.

This is entitlement. If you don’t want to use this, you do not have to.

@nuxt-community nuxt-community deleted a comment from lmf-git Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add Discord Oauth2
6 participants