New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import less Lodash #14

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@leahciMic
Contributor

leahciMic commented Nov 9, 2017

This module imports the entirety of Lodash which is very large. This results in large bundle sizes for anyone consuming this module.

This PR imports only the merge function from Lodash.

@leahciMic leahciMic force-pushed the leahciMic:patch-1 branch from 21aae09 to 25c017a Nov 9, 2017

@pi0

This comment has been minimized.

Member

pi0 commented Nov 9, 2017

Hi and thanks for this PR. Lodash is only required inside nuxt module (Which is a part of nuxt) and modules won't be included in output bundle.So i think this won't make any difference.

Import less Lodash
This module imports the entirety of Lodash which is very large. This results in large bundle sizes for anyone consuming this module.

This PR imports only the merge function from Lodash.

@leahciMic leahciMic force-pushed the leahciMic:patch-1 branch from 25c017a to b923f48 Nov 9, 2017

@leahciMic

This comment has been minimized.

Contributor

leahciMic commented Nov 9, 2017

@pi0 You're totally right, my apologies. I have an update to this (which I forgot to commit and push) that addresses the correct import which is located in auth.store.js. Please take another look.

@pi0

This comment has been minimized.

Member

pi0 commented Nov 9, 2017

Now makes sense. Thanks for your help :)

@pi0 pi0 merged commit fc6ae68 into nuxt-community:master Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment