fix(refresh): prevent duplicating refresh token in parallel requests #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bmulholland, Can we get this merged and release? Thank you! |
5 tasks
trandaison
force-pushed
the
fix/duplicate-refresh-in-parallel-requests
branch
from
e4426a8
to
f2d8b3b
Compare
|
There’s not much point: a rewrite is coming soon |
|
But sure, can merge if you add a comment explaining what this code is doing and why. |
trandaison
force-pushed
the
fix/duplicate-refresh-in-parallel-requests
branch
3 times, most recently
from
9e34ac0
to
b55087e
Compare
trandaison
force-pushed
the
fix/duplicate-refresh-in-parallel-requests
branch
from
b55087e
to
0bcb0b1
Compare
|
@bmulholland Thanks for reviewing.
Can't wait to see the new version of this module. |
bmulholland
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #1772 and #1743