Allow set state in case it exists on oauth2 provider #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you and sorry for the late response |
pi0
reviewed
Feb 10, 2019
| @@ -18,7 +18,8 @@ auth: { | |||
| token_type: 'Bearer', | |||
| redirect_uri: undefined, | |||
| client_id: 'SET_ME', | |||
| token_key: 'access_token' | |||
| token_key: 'access_token', | |||
| state: 'UNIQUE_AND_NON_GUESSABLE' | |||
There was a problem hiding this comment.
This should be random per login not documented here
There was a problem hiding this comment.
My bad
You're right, state must keep random and internal.
We could persist our custom values with auth storage in order to recover them on OAuth2 callback
|
Wouldn't it make sense to also allow for state to be set through arguments of the loginWith and login methods? |
Merged
This was referenced May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some times I need some values to be returned from the auth service and the state param of the Oauth2 scheme give us that option. Right now it sends a random string.