Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set-cookie header contains undefined value #372

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Yama-Tomo
Copy link
Contributor

@Yama-Tomo Yama-Tomo commented Jun 5, 2019

relate #367

Set-Cookie header contains undefined value when prevCookies is empty

screen shot

スクリーンショット 2019-06-05 23 32 05

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #372 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #372   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c636f...3bb14b1. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Jun 5, 2019

Thanks @Yama-Tomo for this fix ❤️

@pi0 pi0 merged commit 323346e into nuxt-community:dev Jun 5, 2019
@Yama-Tomo Yama-Tomo deleted the fix/undefined-set-cookie-header branch Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants