Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't redirect to login page if in guest mode #385

Merged
merged 1 commit into from Jun 23, 2019

Conversation

studnitz
Copy link
Contributor

@studnitz studnitz commented Jun 21, 2019

At the moment when auth: 'guest' is set on a page it always redirect an unauthed user to login, which I think is not the desired effect.

This PR fixes this, as unauthed users are now not redirected to login.

I also took the liberty to make the code more self-explanatory.

Related issue: #383

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #385 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #385   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6811ab5...b329def. Read the comment docs.

pi0
pi0 approved these changes Jun 23, 2019
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 3ee609d into nuxt-community:dev Jun 23, 2019
@studnitz
Copy link
Contributor Author

Oops, actually this introduced a regression if callback: false is set, gonna create a new PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants