fix(oauth2): correctly handle callback with hash #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #394 +/- ##
===================================
Coverage 100% 100%
===================================
Files 1 1
Lines 2 2
===================================
Hits 2 2Continue to review full report at Codecov.
|
pi0
reviewed
Jun 24, 2019
pi0
changed the title
pi0
changed the title
|
Thanks @mmachatschek! |
|
Landed in 4.8.1 |
tanutsun
pushed a commit
to tanutsun/auth-module
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #393
Problem is that with the latest introduction of server-side callback handling #381, the parsing of the hash was removed and therefore the information provided by the oauth clients can not be extracted anymore.