Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return config with credentials #299

Closed
wants to merge 1 commit into from
Closed

fix: return config with credentials #299

wants to merge 1 commit into from

Conversation

ricardogobbosouza
Copy link
Member

Resolve #168

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #299 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #299   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        28     28           
  Branches     13     13           
===================================
  Hits         28     28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb9837...a46d5c5. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Oct 21, 2019

I'm not sure this is a fix. onRequest function already returns original config if nothing returned.

https://github.com/nuxt-community/axios-module/blob/dev/lib/plugin.js#L20

@ricardogobbosouza
Copy link
Member Author

@pi0 you're right

@ricardogobbosouza ricardogobbosouza deleted the fix-credentials branch October 21, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axios withCredentials not being passed from nuxt.config.js
2 participants