Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add x-forwarded-port and x-forwarded-proto to proxyHeaderIgnore defaults #465

Merged
merged 1 commit into from
Jan 11, 2021
Merged

fix: add x-forwarded-port and x-forwarded-proto to proxyHeaderIgnore defaults #465

merged 1 commit into from
Jan 11, 2021

Conversation

bblanchon
Copy link
Contributor

As discussed in #462, ignoring X-Forwarded-Host implies ignoring X-Forwarded-Port and X-Forwarded-Proto as well.

@codecov
Copy link

codecov bot commented Jan 11, 2021 •
edited
Loading

Codecov Report

Merging #465 (3a5cacb) into master (c6e256c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files           1        1           
  Lines          45       45           
  Branches       25       25           
=======================================
  Hits           43       43           
  Misses          2        2
Impacted Files Coverage Δ
lib/module.js 95.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e256c...3a5cacb. Read the comment docs.

pi0
pi0 reviewed Jan 11, 2021
View reviewed changes
lib/module.js Outdated Show resolved Hide resolved
docs/content/en/options.md Outdated Show resolved Hide resolved
docs/content/en/options.md Show resolved Hide resolved
pi0
pi0 approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pi0 pi0 changed the title fix: add x-forwarded-{port,proto} to proxyHeaderIgnore defaults (#462) fix: add x-forwarded-port and x-forwarded-proto to proxyHeaderIgnore defaults Jan 11, 2021
@pi0 pi0 merged commit a1a1894 into nuxt-community:master Jan 11, 2021
@bblanchon bblanchon deleted the x-forwarded branch January 11, 2021 11:24
This was referenced Mar 11, 2021
Merged
Merged
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bblanchon @pi0