isEligible should fire on route change #7
Conversation
| @@ -5,14 +5,23 @@ import experiments from '<%= options.experimentsDir %>' | |||
| const MAX_AGE = <%= options.maxAge %> | |||
|
|
|||
| export default function (ctx, inject) { | |||
| ctx.app.router.beforeEach((to, from, next) => { | |||
There was a problem hiding this comment.
Won't this override any existing function on beforeEach? Just wondering.
There was a problem hiding this comment.
beforeEach is a register that adds callback function, so it won't override existing functions, i think.
https://github.com/vuejs/vue-router/blob/v3.0.2/src/index.js#L121-L123
There was a problem hiding this comment.
Looks like you're right, cool. Didn't know that :)
|
I think I need more considerations before this is accepted, so I close this PR. Sorry for bothering. |
|
@japboy what's the problem? I'd really like to have this functionality too so would like to help if possible. |
|
@tschut first of all, running multiple experiments at once is not ideal way of A/B testing or MVT. second, changing cookie format is necessary to support multiple experiment data to be stored properly. current implementation supports only one experiment at once. and i need some minor fixes if this is merged (like firing multiple route events at once etc...). i think i should define MVT for multiple endpoint experiments instead of firing route event. |
I need this Optimize module and want to run different experiments on each page, so I made #3 possible.