Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: localeProperties undefined when <i18n> component used #1043

Merged
merged 2 commits into from Jan 25, 2021
Merged

fix: localeProperties undefined when <i18n> component used #1043

merged 2 commits into from Jan 25, 2021

Conversation

iifawzi
Copy link

@iifawzi iifawzi commented Jan 25, 2021 •
edited

Fixes: #1023 (comment)

This pull request includes:

  • Assigning the localeProperties in extendVueI18nInstance
  • Altering the test to cover all cases, instead of adding a separate one.
  • re-phrasing the related tests a bit.

@iifawzi iifawzi force-pushed the fix-localeProperties-undefined branch from 6a76222 to 3dbe428 Compare January 25, 2021 08:06
@iifawzi iifawzi changed the title fix: localeProperties object is undefined when vueI18nLoader is set to true fix: localeProperties object is undefined when <i18n> component is used Jan 25, 2021
@rchl rchl changed the title fix: localeProperties object is undefined when <i18n> component is used fix: localeProperties undefined when <i18n> component used Jan 25, 2021
@rchl rchl merged commit ff56a35 into nuxt-modules:master Jan 25, 2021
@rchl
Copy link
Collaborator

rchl commented Jan 25, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iifawzi @rchl