fix: localeProperties undefined when <i18n> component used (#1043)

nuxt-modules · Jan 25, 2021 · ff56a35 · ff56a35
1 parent 9cd9452
commit ff56a35
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/src/templates/plugin.main.js b/src/templates/plugin.main.js
@@ -252,6 +252,7 @@ export default async (context) => {
 
   const extendVueI18nInstance = i18n => {
     i18n.locales = locales
+    i18n.localeProperties = klona(locales.find(l => l[LOCALE_CODE_KEY] === i18n.locale) || { code: i18n.locale })
     i18n.defaultLocale = defaultLocale
     i18n.differentDomains = differentDomains
     i18n.beforeLanguageSwitch = beforeLanguageSwitch

diff --git a/test/fixture/basic/pages/loader-yaml.vue b/test/fixture/basic/pages/loader-yaml.vue
@@ -2,6 +2,7 @@
   <div>
     <p id="title">{{ $t('hello') }}</p>
     <p id="locales">{{ locales }}</p>
+    <p id="localeProperties">{{ JSON.stringify(localeProperties) }}</p>
   </div>
 </template>
 
@@ -10,6 +11,9 @@ export default {
   computed: {
     locales () {
       return this.$i18n.locales || []
+    },
+    localeProperties () {
+      return this.$i18n.localeProperties || {}
     }
   }
 }

diff --git a/test/module.test.js b/test/module.test.js
@@ -732,13 +732,17 @@ describe('hreflang', () => {
     expect(seoTags).toEqual(expectedSeoTags)
   })
 
-  test('localeProperties object exists and is set to the correct value', async () => {
-    const window = await nuxt.renderAndGetWindow(url('/'))
-    expect(window.$nuxt.$i18n.localeProperties).toEqual({
-      code: 'en',
-      iso: 'en',
-      name: 'English'
-    })
+  test('localeProperties object exists and is set to the correct object', async () => {
+    const html = await get('/loader-yaml')
+    const dom = getDom(html)
+    const localeProperties = dom.querySelector('p#localeProperties')
+    const localePropertiesContent = localeProperties?.textContent || '{}'
+    expect(JSON.parse(localePropertiesContent)).toMatchObject(
+      {
+        code: 'en',
+        iso: 'en',
+        name: 'English'
+      })
   })
 
   afterAll(async () => {
@@ -825,7 +829,7 @@ describe('with empty configuration', () => {
     await nuxt.renderAndGetWindow(url('/about'))
   })
 
-  test('localeProperties object exists and is set to an empty object ', async () => {
+  test('localeProperties object exists and is set to an object with no code', async () => {
     const window = await nuxt.renderAndGetWindow(url('/'))
     expect(window.$nuxt.$i18n.localeProperties).toEqual({ code: '' })
   })