Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract bulma-module #398

Closed
6 of 9 tasks
Geminii opened this issue Jan 18, 2021 · 5 comments · Fixed by #399
Closed
6 of 9 tasks

Extract bulma-module #398

Geminii opened this issue Jan 18, 2021 · 5 comments · Fixed by #399

Comments

@Geminii
Copy link
Contributor

Geminii commented Jan 18, 2021

I don't find any repository on nuxt-community/bulma-module

Tasks :

@pi0 @Atinux

Copy link
Member

Atinux commented Jan 19, 2021

I am wondering if this is required since it is only adding a CSS file 🤔

Also, buefy is doing a great job and has a Nuxt installation: https://buefy.org/documentation/start#nuxtjs

@Geminii
Copy link
Contributor Author

Geminii commented Jan 19, 2021

I am wondering if this is required since it is only adding a CSS file 🤔

Yes for the moment, this module only include a css file but maybe we can evolve the module ? Add some configurations or other ? Dunno if there is an interest about it?

Also, buefy is doing a great job and has a Nuxt installation: https://buefy.org/documentation/start#nuxtjs

Buefy is based on Bulma and there is already a module for it (https://github.com/buefy/nuxt-buefy).
If a developper want to only include Bulma without Buefy addons, do you think in this case that Buefy need to be include in this context ?

Copy link
Member

Atinux commented Jan 19, 2021

Yes for the moment, this module only include a css file but maybe we can evolve the module ? Add some configurations or other ? Dunno if there is an interest about it?

I don't think a module for this is necessary honestly. Great documentation about adding CSS frameworks in Nuxt should be enough.

If a developper want to only include Bulma without Buefy addons, do you think in this case that Buefy need to be include in this context ?

Then he simply need to:

yarn add --dev bulma

And set in his nuxt.config.js:

export default {
  css: ['bulma/css/bulma.css']
}

Is it as fast as using a module and can upgrade more easily.

CC @pi0, what do you think?

@pi0
Copy link
Member

pi0 commented Jan 20, 2021

Fully agree. With buefiy, this module doesn't makes sense anymore and should be deprecated. Also made issue for CNA removal: nuxt/create-nuxt-app#694

@pi0 pi0 closed this as completed Jan 20, 2021
@Geminii
Copy link
Contributor Author

Geminii commented Jan 20, 2021

Ok in this way, i will remove the bulma-module. It make no sense to keep it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants