Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load fallback locale when needed if lazy-loading (fixes #34) #291

Merged
merged 1 commit into from
May 6, 2019
Merged

Load fallback locale when needed if lazy-loading (fixes #34) #291

merged 1 commit into from
May 6, 2019

Conversation

rchl
Copy link
Collaborator

@rchl rchl commented May 6, 2019

Fallback locale is needed to properly handle strings that exist in
base/fallback locale but not in currently used one.

Fix from @orblazer

Fallback locale is needed to properly handle strings that exist in
base/fallback locale but not in currently used one.

Fix from @orblazer
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #291   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5658211...f9c1092. Read the comment docs.

@paulgv paulgv merged commit 1fc26c3 into nuxt-modules:master May 6, 2019
@paulgv
Copy link
Collaborator

paulgv commented May 6, 2019

Thanks for picking this up @rchl! Thanks for submitting the initial fix @orblazer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants