-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional catchall hreflang tags #597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 121 121
Branches 31 31
=====================================
Hits 121 121 Continue to review full report at Codecov.
|
I thought the idea was to add that more-generic meta tag in addition to original one, rather than replace it. Also, I would like this to be more automatic. I was thinking to include the list of all locales in the module and derive one automatically (from first locale-country code seen, for example). Of course, it would still be possible to override that with an extra property. As for the property name, maybe call it something closer to documentation - for example And the new property should be documented in |
UPDATE: As shown in this article it is reasonable to do so. will work on an implementation
Makes sense!
Will change
True! |
How about that part (see emphasis)?
|
@rchl Yup, you are right! Already correct my psot above after seeing another confirming tweet from John Mueller |
We should also have test that uses Also a friendly reminder about documentation. :) |
Covered in a separate fixture!
Done now as well, thanks for the reminder 👍🏻 |
Resolves #522