Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert back to generating routes from extendRoutes() #751

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

rchl
Copy link
Collaborator

@rchl rchl commented Jun 2, 2020

Changing to using the "build:extendRoutes" hook wasn't necessary and
was a breaking changed for users who use extendRoutes() and expect
nuxt-i18n to process those routes.

Resolves #750

Changing to using the "build:extendRoutes" hook wasn't necessary and
was a breaking changed for users who use extendRoutes() and expect
nuxt-i18n to process those routes.

Resolves #750
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #751 into master will increase coverage by 0.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   97.67%   98.44%   +0.77%     
==========================================
  Files           3        3              
  Lines         129      129              
  Branches       35       35              
==========================================
+ Hits          126      127       +1     
+ Misses          3        2       -1     
Impacted Files Coverage Δ
src/index.js 97.87% <100.00%> (ø)
src/helpers/routes.js 98.38% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba69d87...1ee103b. Read the comment docs.

@rchl rchl merged commit 439781f into master Jun 2, 2020
@rchl rchl deleted the fix/extend-route-order branch June 2, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not created extendroutes
1 participant