Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneSignal loaded twice in built SPA #6

Open
motia opened this issue Mar 8, 2019 — with CMTY · 4 comments
Open

OneSignal loaded twice in built SPA #6

motia opened this issue Mar 8, 2019 — with CMTY · 4 comments

Comments

Copy link

motia commented Mar 8, 2019

Version

v3.0.0-beta.12

Reproduction link

https://github.com/motia/nuxt-onesignal-fresh

Steps to reproduce

git clone https://github.com/motia/nuxt-onesignal-fresh.git
yarn
yarn nuxt build

The SPA must be served on the domain other.test, otherwise you must change use your key.

What is expected ?

The script is loaded once form built SPA.

What is actually happening?

onesignal-twice.PNG

Additional comments?

This bug should not be problematic, because the script is loaded from a cdn with long cache.

This bug report is available on Nuxt community (#c106)
@pi0
Copy link
Member

pi0 commented Mar 17, 2019

Hi and thanks for the report. This is normal that two onesignal related js files added (one is for update checks) but they should not be identical like the image above.

image

I've added a fix to ensure this behavior. Please check it on latest version and ping me if problem still happens.

@pi0 pi0 closed this as completed Mar 17, 2019
@8ctopotamus
Copy link

8ctopotamus commented Mar 22, 2019

I have this issue too. Do I just reinstall the Nuxt PWA module in order to fix this?

@motia
Copy link
Author

motia commented Apr 30, 2019

yes. the problem persists.

Copy link

EricBois commented Nov 13, 2019

i have the same problem

@pi0 pi0 transferred this issue from nuxt-community/pwa-module Apr 16, 2020
@pi0 pi0 reopened this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants