fix: relax pages regex for workbox 4 compatiblity

pooya parsa · pooya parsa · commit 04e74a7843ea · 2019-02-08T17:15:14.000+03:30
diff --git a/docs/modules/workbox.md b/docs/modules/workbox.md
@@ -141,7 +141,7 @@ Default: `/_nuxt/(?!.*(__webpack_hmr|hot-update))`
 
 Default is auto generated based on `router.base`.
 
-Default: `^/(?!.*(__webpack_hmr|hot-update))`
+Default: `/(?!.*(__webpack_hmr|hot-update))`
 
 <!-- SW -->
 
diff --git a/packages/workbox/lib/options.js b/packages/workbox/lib/options.js
@@ -53,7 +53,7 @@ function getOptions (moduleOptions) {
 
   // Optionally cache other routes for offline
   if (!options.pagesURLPattern) {
-    options.pagesURLPattern = joinUrl(`^${options.routerBase}`, HMRRegex)
+    options.pagesURLPattern = joinUrl(options.routerBase, HMRRegex)
   }
   if (options.offline && !options.offlinePage) {
     options.runtimeCaching.push({
diff --git a/test/__snapshots__/pwa.test.js.snap b/test/__snapshots__/pwa.test.js.snap
@@ -107,7 +107,7 @@ workbox.routing.registerRoute(new RegExp('https://google.com/.*'), new workbox.s
 workbox.routing.registerRoute(new RegExp('/_nuxt/(?!.*(__webpack_hmr|hot-update))'), new workbox.strategies.CacheFirst ({}), 'GET')
 
 // Register router handler for offlinePage
-workbox.routing.registerRoute(new RegExp('^/(?!.*(__webpack_hmr|hot-update))'), ({event}) => {
+workbox.routing.registerRoute(new RegExp('/(?!.*(__webpack_hmr|hot-update))'), ({event}) => {
   return new workbox.strategies.NetworkOnly().handle({event})
     .catch(() => caches.match('/offline.html'))
 })
diff --git a/test/hmr.js b/test/hmr.js
@@ -11,7 +11,7 @@ const regexes = {
   cacheFirstCDN: new RegExp(`${CSNPublicPath}/${HMRRegex}`),
 
   // Regex for networkFist
-  networkFirst: new RegExp(`^/${HMRRegex}`)
+  networkFirst: new RegExp(`/${HMRRegex}`)
 }
 
 const lists = {

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ function getOptions (moduleOptions) {`
`53`	`53`
`54`	`54`	`// Optionally cache other routes for offline`
`55`	`55`	`if (!options.pagesURLPattern) {`
`56`		- options.pagesURLPattern = joinUrl(`^${options.routerBase}`, HMRRegex)
	`56`	`+ options.pagesURLPattern = joinUrl(options.routerBase, HMRRegex)`
`57`	`57`	`}`
`58`	`58`	`if (options.offline && !options.offlinePage) {`
`59`	`59`	`options.runtimeCaching.push({`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ const regexes = {`
`11`	`11`	cacheFirstCDN: new RegExp(`${CSNPublicPath}/${HMRRegex}`),
`12`	`12`
`13`	`13`	`// Regex for networkFist`
`14`		- networkFirst: new RegExp(`^/${HMRRegex}`)
	`14`	+ networkFirst: new RegExp(`/${HMRRegex}`)
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`const lists = {`