refactor: use tapable hooks (#103)

BREAKING CHANGE: webpack >= 4 (Nuxt >= 2) is required
nuxt-community · Nov 11, 2018 · 9f27d5c · 9f27d5c
1 parent e9062be
commit 9f27d5c
Show file tree

Hide file tree

Showing 4 changed files with 1,484 additions and 6 deletions.
diff --git a/packages/icon/index.js b/packages/icon/index.js
@@ -95,14 +95,13 @@ function generateIcons (moduleOptions) {
       // Register webpack plugin to emit icons
       this.options.build.plugins.push({
         apply (compiler) {
-          compiler.plugin('emit', function (compilation, _cb) {
+          compiler.hooks.emit.tap('nuxt-pwa-icon', compilation => {
             icons.forEach(icon => {
               compilation.assets[icon.fileName] = {
                 source: () => icon.buff,
                 size: () => icon.buff.length
               }
             })
-            _cb()
           })
         }
       })

diff --git a/packages/manifest/index.js b/packages/manifest/index.js
@@ -60,12 +60,11 @@ function addManifest (options) {
   // Register webpack plugin to emit manifest
   this.options.build.plugins.push({
     apply (compiler) {
-      compiler.plugin('emit', function (compilation, cb) {
+      compiler.hooks.emit.tap('nuxt-pwa-manifest', (compilation) => {
         compilation.assets[manifestFileName] = {
           source: () => manifestSource,
           size: () => manifestSource.length
         }
-        cb()
       })
     }
   })

diff --git a/packages/onesignal/index.js b/packages/onesignal/index.js
@@ -71,12 +71,11 @@ function addOneSignal (moduleOptions) {
 
       this.options.build.plugins.push({
         apply (compiler) {
-          compiler.plugin('emit', function (compilation, cb) {
+          compiler.hooks.emit.tap('nuxt-pwa-onesignal', (compilation) => {
             compilation.assets[OneSignalSDKFile] = {
               source: () => OneSignalSDKJS,
               size: () => OneSignalSDKJS.length
             }
-            cb()
           })
         }
       })