ensure oneSignalSDKWorker.js resolves when using nested routes #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Scott. Thanks for your PR and nice to see Push of Love using Nuxt and PWA modules! The root cause was that we need to always prepend routerBase (Which is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that
oneSignalSDKWorker.jsdoes not properly resolve when using nested routes.I attempted to write a test for this but couldn't figure out a good way to test it -- If we think it's valuable I'd be more than happy to write one/some if someone can provide me with some guidance.
Here's an example of the problem:
It's also actively occurring on my website if it helps to see it live: https://pushoflove.com/feed/63b77785-806b-41b9-9e7a-c8813d79a1bf