Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable to set skipWaiting for workbox #80

Merged
merged 3 commits into from
Aug 24, 2018

Conversation

gyarasu
Copy link
Contributor

@gyarasu gyarasu commented Aug 16, 2018

So far, it is impossible to set skipWaiting to workbox.
I added the option.
The default value is true to adjust clientsClaim because they are used together commonly.

regards
Hiroki

…herefore the default value is the same as `clientsCalim`.
@gyarasu
Copy link
Contributor Author

gyarasu commented Aug 16, 2018

Originally, these default value are false in workbox.
https://developers.google.com/web/tools/workbox/modules/workbox-build

Anyone knows the reason that clientClaim default is true?

@pi0
Copy link
Member

pi0 commented Aug 24, 2018

@galvez Would you please check it out? Can we bring it with #60?

@galvez
Copy link
Contributor

galvez commented Aug 24, 2018

@pi0 in v3 it needs to be a method call (i.e., workbox.skipWaiting()) -- I'll update this branch and merge after #60

@pi0 pi0 changed the base branch from master to develop August 24, 2018 10:04
@pi0 pi0 merged commit 88cc602 into nuxt-community:develop Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants