Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dataSize default overriding actual config #85

Merged
merged 1 commit into from
Mar 21, 2021
Merged

fix: dataSize default overriding actual config #85

merged 1 commit into from
Mar 21, 2021

Conversation

andrewmurraydavid
Copy link
Contributor

@mangrove108 can you try to pull this change down and test it out?

You can install the npm module from the folder:

git clone https://github.com/andrewmurraydavid/recaptcha-module.git 
git checkout  override-dataSize

cd /your/project/dir
npm i /the/repo/you/just/cloned
# run your project

@mvrlin this PR should close #84

@ghost
Copy link

ghost commented Mar 16, 2021

@mangrove108 can you try to pull this change down and test it out?

You can install the npm module from the folder:

git clone https://github.com/andrewmurraydavid/recaptcha-module.git 
git checkout  override-dataSize

cd /your/project/dir
npm i /the/repo/you/just/cloned
# run your project

@mvrlin this PR should close #84

tomorrow 😄👍

@andrewmurraydavid
Copy link
Contributor Author

Sounds great! Thank you!
Again, I apologize for the breaking change 😅

@ghost
Copy link

ghost commented Mar 17, 2021

Sounds great! Thank you!
Again, I apologize for the breaking change 😅

yipp i did npm install https://github.com/andrewmurraydavid/recaptcha-module.git, but to no avail, i will wait ...

@andrewmurraydavid
Copy link
Contributor Author

andrewmurraydavid commented Mar 18, 2021

yipp i did npm install https://github.com/andrewmurraydavid/recaptcha-module.git, but to no avail, I will wait ...

I apologize for the late response, it's been a long day at work. I've created a temporary npm package (don't worry @mvrlin, I will remove this when we solve this issue).

@mangrove108 feel free to install the temporary package I created to test the changes:

npm i @andrewmurraydavid/recaptcha@1.0.4-alpha.1

You will also need to change the module in nuxt.config.js

-'@nuxtjs/recaptcha',
+'@andrewmurraydavid/recaptcha',

Feel free to add me on discord (see my profile). More than happy to take the time and do a paired session to see exactly what's breaking on your side and get it fixed.

@Risen-Solutions
Copy link

Just opened, and then closed, issue #88 as this pull request seems to fix the error with recaptcha showing.

@andrewmurraydavid
Copy link
Contributor Author

I apologize for the late response, it's been a long day at work. I've created a temporary npm package (don't worry @mvrlin, I will remove this when we solve this issue).

@mangrove108 feel free to install the temporary package I created to test the changes:

npm i @andrewmurraydavid/recaptcha@1.0.4-alpha.1

You will also need to change the module in nuxt.config.js

-'@nuxtjs/recaptcha',

+'@andrewmurraydavid/recaptcha',

Feel free to add me on discord (see my profile). More than happy to take the time and do a paired session to see exactly what's breaking on your side and get it fixed.

@mangrove108 did you get a chance to test the changes?

@Risen-Solutions could you checkout and try to test this solution?

Thanks!

@Risen-Solutions
Copy link

Hi All. I can confirm that I have checked out "@andrewmurraydavid/recaptcha": "^1.0.4-alpha.1" and it seems to be working fine in the project. Phoenix

@andrewmurraydavid
Copy link
Contributor Author

Thank you @Risen-Solutions!

@mvrlin could you take a look at the PR?

Thanks!

@mvrlin mvrlin merged commit a25daf7 into nuxt-community:master Mar 21, 2021
@mvrlin
Copy link
Member

mvrlin commented Mar 21, 2021

@andrewmurraydavid Thanks for the PR!

@ghost
Copy link

ghost commented Mar 21, 2021

@andrewmurraydavid yipp works, thank you 👌👍

@mobi35
Copy link

mobi35 commented Aug 7, 2021

npm i @andrewmurraydavid/recaptcha
'@andrewmurraydavid/recaptcha@^1.0.4-alpha.1' is not in the npm registry.
I can't install it sir. Do you have the updated links?

have the same error..
ERROR for site owner: Invalid key type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error message: "Error message to website owners: Invalid key type"
4 participants