Accept to param as function for redirect rule #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 19 22 +3
Branches 4 5 +1
=====================================
+ Hits 19 22 +3
Continue to review full report at Codecov.
|
|
Hey @juno-yu! Thanks for the PR and well done! I've added a small annotation with regards to |
manniL
reviewed
Oct 16, 2018
lib/middleware.js
Outdated
| // Expect rule 'to' to be 1)regex or 2)string or 3)synchronous function taking from to compute to | ||
| let toTarget = foundRule.to | ||
| if (typeof toTarget === 'function') { | ||
| toTarget = toTarget(foundRule.from) |
There was a problem hiding this comment.
It'd be great if the function could be awaited for in case it's async!
juno-yu
commented
Oct 16, 2018
|
@juno-yu Alright, almost good to go! Could you update the |
|
@juno-yu ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A preminilary impl which resolves #2
(Sorry got a bug, async WIP)