-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentry config issues #226
Comments
Looking at it a bit more maybe it doesnt matter at all because these props arent used when reading sentry.server.config.js? |
I was checking this out and there actually seems to be pretty bad issue that drops
is overwriting |
Well, as you said, it works in practice but still is kinda unexpected. |
👍
As you probably know, the core team discourages serialization of functions.
(see also internal discussion about that at https://discord.com/channels/473401852243869706/735157506300575775/747511148282118495 ) |
Thanks. Actually I dont have a big issue with serializing functions, at least not in how we should use them here as part of an external config object. I agree we should discourage it as much as possible and should look for a better way of passing module options in v3, but for v2 we shouldnt implement & spent time on implementations mostly for the sake of code purity. Especially when it only makes configuration more difficult and isnt rly needed for like 99% of the use-cases. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
The first two points from the initial comment should be working just fine now. The third point about serializing |
Was looking at my sentry config and noticed a couple of issues
value instanceof RegExp
and then just callvalue.toString()
?beforeSend
fn to your options. Nuxt should already provide aserializeFunction
helper in the template context, maybe we could use that or did you use String for functions on purpose?The text was updated successfully, but these errors were encountered: