Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling automatic version detection for releases #314

Merged

Conversation

jakub300
Copy link
Contributor

This small change allows release to be set to undefined without being overridden with automatic release.

In v4 it was possible to set clientConfig: { release: undefined } (and same for server) to override automatically generated value. In v5 the merging library has been changed to lodash.merge which is ignoring undefined values making it no longer possible to override automatic release generation.

We prefer not to include release in the configuration to avoid unnecessary changes to built files (small perf improvement for returning visitors). Instead we rely on window.SENTRY_RELEASE/process.env.SENTRY_RELEASE. For that to work release must be undefined.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #314 (3d64204) into master (9e3ae22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           1        1           
  Lines          27       27           
  Branches        8        8           
=======================================
  Hits           15       15           
  Misses          9        9           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3ae22...3d64204. Read the comment docs.

@rchl rchl changed the title feat: Allow release to be set to falsy value feat: allow disabling automatic version detection for releases Apr 28, 2021
@rchl rchl merged commit e1677fa into nuxt-community:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants