feat: allow config to be passed to requestHandler

[teajaymars]

RequestHandler takes a lot of interesting options such as { ip: true }. With this small tweak it is possible to pass in these values to Sentry's handler.

[rchl]

Would also need:

• documenation
• extending type declaration
• adding default (empty object I guess) configuration

[codecov]

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           1        1           
  Lines          27       27           
  Branches        8        8           
=======================================
  Hits           15       15           
  Misses          9        9           
  Partials        3        3           

Impacted Files	Coverage Δ
lib/module.js	55.55% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281656a...831e2b3. Read the comment docs.

[teajaymars]

Quite right, but those types were only `export`ed within the last couple of weeks. The version on my local checkout _does not_ export those types so I've chosen to duplicate them for backward compatibility.

…

On Fri, 23 Oct 2020 at 13:02, Rafał Chłodnicki ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In types/sentry.d.ts <#243 (comment)> : > @@ -13,6 +13,17 @@ export interface LazyConfiguration { webpackPreload?: boolean } +type TransactionTypes = 'path' | 'methodPath' | 'handler' +export interface RequestHandlerConfiguration { You should import those types directly from @sentry/types instead of duplicating them. Only that it seems like you won't be able to use flushTimeout directly so you have to add that manually. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#243 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAWWCRSJQ7KPNWXGRT6F4TSMFWFVANCNFSM4S34TO7Q> .

-- Tom Rees CEO http://datapress.com

[teajaymars]

For reference - 21 days ago getsentry/sentry-javascript@b4a29be

[rchl]

But that's ok because master branch of this module has updated to latest sentry dependencies so those types will be available.

[rchl]

Thanks!

[teajaymars]

Thanks for sorting this out! I'm sorry I dropped off, I have just finished moving house, haven't had internet for a few days.

Appreciate the new feature!