Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace axios with @nuxtjs/axios #32

Closed
AndrewBogdanovTSS opened this issue Feb 7, 2018 · 4 comments
Closed

Replace axios with @nuxtjs/axios #32

AndrewBogdanovTSS opened this issue Feb 7, 2018 · 4 comments

Comments

@AndrewBogdanovTSS
Copy link

AndrewBogdanovTSS commented Feb 7, 2018

Since we have a @nuxtjs/axios modification that is specifically crafted for use together with Nuxt it will be more logical to use it inside this template

This question is available on Nuxt.js community (#c26)
@qm3ster
Copy link
Member

qm3ster commented Feb 7, 2018

Possible. But that's an extra dependency that might go unmaintained, and takes up space in the bundle.
Perhaps there should not be axios in this template at all, or it should at least be an option.
For instance, it causes #3
The template is called typescript-template not axios-GSAP-tachyons-decorator-vuex_class-template
At least the component classes make sense because they improve type information (directly related to this being typescript)

@AndrewBogdanovTSS
Copy link
Author

Yeah, I agree. tachyons dependency bugs me the most, I'm not a fan of this lib and I don't see a huge benefit of its existing in the project. GSAP is also feeling unneeded here, it isn't even used anywhere in the code. Though I don't think axios should be removed since it showcases a workflow of requesting the data from the server which is quite common in any nuxt based app. We can make it optional via a question prompted during template initialization. What do you think?

@qm3ster
Copy link
Member

qm3ster commented Feb 10, 2018

What if you want to use isomorphic fetch or something instead of axios?
I agree to optional.

@hmsk
Copy link
Member

hmsk commented Jan 7, 2019

Now it's running with @nuxtjs/axios since 22d0c56 at all.
Open the issue if we intend to use axios directly 🤔

@hmsk hmsk closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants