Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass-loader bump version in pull request #453 is causing build failure. #484

Closed
maxerbox opened this issue Nov 29, 2021 · 7 comments
Closed

Comments

@maxerbox
Copy link

maxerbox commented Nov 29, 2021

Module version
1.12.2

Describe the bug
sass-loader bump version in pull request #453 is causing build failure.

in ./node_modules/vuetify/src/components/VApp/VApp.sass

Module build failed (from ./node_modules/@nuxtjs/vuetify/node_modules/sass-loader/dist/cjs.js):
TypeError: this.getOptions is not a function
    at Object.loader (/mnt/6c613b3f-1cec-40c0-a5fb-0e771e22f7c2/home/mxb/Documents/xxx/packages/wb-ui/node_modules/@nuxtjs/vuetify/node_modules/sass-loader/dist/index.js:25:24)

 @ ./node_modules/vuetify/src/components/VApp/VApp.sass 4:14-232 15:3-20:5 16:22-240
 @ ./node_modules/vuetify/lib/components/VApp/VApp.js
 @ ./node_modules/vuetify/lib/components/VApp/index.js
 @ ./layouts/error.vue
 @ ./.nuxt/index.js
 @ ./.nuxt/client.js
 @ multi ./node_modules/eventsource-polyfill/dist/browserify-eventsource.js (webpack)-hot-middleware/client.js?reload=true&timeout=30000&ansiColors=&overlayStyles=&path=%2F__webpack_hmr%2Fclient&name=client ./.nuxt/client.js

Additional context
sass-loader from version 11 is only compatible with webpack 5.

I'm using nuxt 2

It should be considered as a breaking change

@mschoeffmann
Copy link

same here. reverted to 1.12.1

@dgrabla
Copy link

dgrabla commented Nov 29, 2021

Yeah, same here. A temporal workaround that works for us is to install an older version of the dependency that causes the problem as a direct dependency of your project:

> npm install --save sass-loader@10.2.0

@n1ngu
Copy link

n1ngu commented Nov 30, 2021

Am I missing something or this should be reverted?

@rahulkumarsingh73690
Copy link

+1

@n1ngu
Copy link

n1ngu commented Dec 9, 2021

An immediate action could be yanking @nuxtjs/vuetify@1.12.2 from npm so that no more people runs into this bug. And also to prevent any dependency updating workflow to resolve this exact version while saving the whole user community from the burden of either freezing to 1.12.1 or requiring sass-loader@10 and committing to undo any workaround in the near future.

@kevinmarrec sorry to bother you. Which maintainer should be pinged for this task?

@clarkdo
Copy link
Member

clarkdo commented Dec 12, 2021

v1.12.3 has been released with reverting sass-loader to v10

@maxerbox
Copy link
Author

closed by #487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants