Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TAsyncQuery type and context value as 4th argument #571

Merged

Conversation

TimvdEijnden
Copy link
Contributor

The type TAsyncQuery was missing the context property

type TAsyncQuery<T> = {
  cache?: boolean,
  context?: DefaultContext,
  clientId?: string,
  key?: string,
  query: TQuery<T>,
  variables?: TVariables<T>,
}

Also when passing the context as a 4th argument to useAsyncQuery it would not be applied because it was only checking the options args?.[0]?.context now it also uses args?.[3] and clientId is the 3rd one so it should be args?.[2].

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for apollo-module canceled.

Name Link
🔨 Latest commit b872dda
🔍 Latest deploy log https://app.netlify.com/sites/apollo-module/deploys/655b67ea46b7870008055da9

@Diizzayy Diizzayy self-assigned this Nov 23, 2023
@Diizzayy Diizzayy merged commit 67623b0 into nuxt-modules:v5 Nov 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants