fix: inject color-mode script with nitro plugin (handles mixed spa/ssr) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
changed the title
ssr: false
Atinux
approved these changes
Sep 22, 2022
pi0
reviewed
Sep 22, 2022
| config.virtual = config.virtual || {} | ||
| config.virtual['#color-mode-options'] = `export const script = ${JSON.stringify(options.script, null, 2)}` | ||
| config.plugins = config.plugins || [] | ||
| config.plugins.push(resolve(runtimeDir, 'nitro-plugin')) |
There was a problem hiding this comment.
Refactor tip: We can use defu to assign with defaults being applied.
pi0
reviewed
Sep 22, 2022
|
|
||
| export default <NitroAppPlugin> function (nitro) { | ||
| nitro.hooks.hook('render:html', (htmlContext) => { | ||
| htmlContext.head.push(`<script>${script}</script>`) |
There was a problem hiding this comment.
Small perf: string does needs to be generated once (could be inside function body too but out of hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, instead of injecting the script with a client-side plugin, adds it via a nitro plugin. This should improve stability and reduce the client-side JS payload.
More importantly, it also handles the case of rendering a SPA fallback in an otherwise SSR deployment, which was otherwise broken.