Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#68 is back: Uncaught ReferenceError: assignment to undeclared variable adsbygoogle #132

Closed
dargmuesli opened this issue Aug 6, 2021 · 2 comments · Fixed by #138
Closed

#68 is back: Uncaught ReferenceError: assignment to undeclared variable adsbygoogle #132

dargmuesli opened this issue Aug 6, 2021 · 2 comments · Fixed by #138

Comments

@dargmuesli
Copy link
Contributor

With version 1.4.0 storybook is now loading forever again with a console error showing what was fixed in #68 in the past already.

Looks like the error comes from https://github.com/nuxt-community/google-adsense-module/pull/127/files#diff-cdd77182e73349d6c83fbbce1cccf6f15972fbece4dbd9c52eececf1ca3bfcd5R84 and https://github.com/nuxt-community/google-adsense-module/pull/127/files#diff-cdd77182e73349d6c83fbbce1cccf6f15972fbece4dbd9c52eececf1ca3bfcd5R93.
@farnabaz
Copy link
Collaborator

farnabaz commented Aug 9, 2021

Hey @dargmuesli,
Do you confirm that applying change in #68 to latest version resolve the issue?
Feel free to open a PR, contribution is more that welcome

@dargmuesli dargmuesli mentioned this issue Aug 26, 2021
Merged
@dargmuesli
Copy link
Contributor Author

Sorry for taking a while, I took some time off. Do you plan to release a new version containing this fix soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module): add window as property owner
2 participants
@farnabaz @dargmuesli