Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated beforeLanguageSwitch #1200

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

divine
Copy link

@divine divine commented Jun 18, 2021

Remove deprecated beforeLanguageSwitch

@divine divine closed this Jun 18, 2021
@rchl
Copy link
Collaborator

rchl commented Jun 18, 2021

Note: While doing those changes, it would be nice to at the same time start adding info about breaking changes to migrating.md. It will be harder to miss something if we do it right away.

@divine
Copy link
Author

divine commented Jun 18, 2021

Note: While doing those changes, it would be nice to at the same time start adding info about breaking changes to migrating.md. It will be harder to miss something if we do it right away.

I'm not the best at writing English migration guides, however, I will try my best.

Thanks!

@divine divine reopened this Jun 18, 2021
@rchl
Copy link
Collaborator

rchl commented Jun 18, 2021

We can reword later. It would be enough to just mention the change and suggest alternative.

@divine
Copy link
Author

divine commented Jun 22, 2021

@rchl anything is left here?

Should I continue pushing PRs while this one is open?

Thanks!

@rchl rchl changed the title feat!: remove deprecated beforeLanguageSwitch refactor!: remove deprecated beforeLanguageSwitch Jun 22, 2021
@rchl rchl merged commit 7ef9b9c into nuxt-modules:next Jun 22, 2021
@rchl
Copy link
Collaborator

rchl commented Jun 22, 2021

Thanks!

@divine divine deleted the deprecated-beforelanguageswitch branch June 22, 2021 10:27
@rchl rchl mentioned this pull request Jul 29, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants