Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: injection fields completion for nuxt app instance and page meta #1711

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

kazupon
Copy link
Collaborator

@kazupon kazupon commented Dec 9, 2022

πŸ”— Linked issue

resolves #1704

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR is to ensure that interpolation for fields injected into the nuxt app also works for injections by Nuxt and the user's plugins provided.

The old way was to generate the type in the Nuxt template dynamically, but that way overwrites the existing type, which was as described in #1704.

This PR is for the same issue, although PageMeta's type generation also involves a destructive change.
It's fixed to nuxtI18n only, but that key rarely conflicts with user-defined keys in PageMeta.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@kazupon
Copy link
Collaborator Author

kazupon commented Dec 9, 2022

This is WIP

@kazupon kazupon merged commit 8e682a6 into next Dec 9, 2022
@kazupon kazupon deleted the fix/1704 branch December 9, 2022 16:33
@userquin userquin mentioned this pull request Jan 21, 2023
4 tasks
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
…nuxt-modules#1711)

* fix!: injection fields completion for nuxt app instance and page meta

* fix: getComposer type error

* updates

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8.0.0-beta.6] i18n module prevents plugins from receiving type
1 participant