Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alias): do not use runtime version during nuxt prepare #2180

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix(alias): do not use runtime version during nuxt prepare #2180

merged 2 commits into from
Jul 3, 2023

Conversation

yassilah
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Using vue-i18n runtime version only in dev mode results in wrong/no types when running nuxt prepare. This PR fixes it.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

kazupon
kazupon approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good contribution!
Thanks!

@kazupon kazupon merged commit 7c20648 into nuxt-modules:next Jul 3, 2023
8 checks passed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@yassilah
fix(alias): do not use runtime version during nuxt prepare (nuxt-modu…
6d4abed 
…les#2180)

* fix(alias): do not use runtime version during nuxt prepare

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yassilah @kazupon