Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: messages provided by layer vuei18n config files not merging #2286

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix: messages provided by layer vuei18n config files not merging #2286

merged 2 commits into from
Aug 2, 2023

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

Not sure if this issue has been encountered yet.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Messages provided by vueI18n config files from layers were not being merged.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede force-pushed the fix/layer-vuei18n-options-messages-merge branch from ea1f868 to 9904cf1 Compare August 1, 2023 17:34
kazupon
kazupon approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Thanks!

@kazupon kazupon merged commit f54430a into nuxt-modules:next Aug 2, 2023
5 checks passed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@BobbieGoede
fix: messages provided by layer vuei18n config files not merging (nux…
c6332e7 
…t-modules#2286)

* fix: layer vuei18n options messages not merging

* test: layers vueI18n options test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BobbieGoede @kazupon