Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n layer vue i18n resolution #2347

Merged

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

#2343

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This changes resolveLayerVueI18nConfigInfo to only try to resolve Vue I18n configuration paths for layers that contain configuration for @nuxtjs/i18n.

@kazupon would this be correct or is it possible and should we take into account layers could have an i18n.config file without using @nuxtjs/i18n?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Collaborator

kazupon commented Aug 26, 2023

would this be correct or is it possible and should we take into account layers could have an i18n.config file without using @nuxtjs/i18n?

Yes, this is correct.
We shouldn't take into account an i18n.config file without using @nuxtjs/i18n.

@kazupon kazupon merged commit 0ce016a into nuxt-modules:next Aug 26, 2023
4 checks passed
@dargmuesli
Copy link
Collaborator

How is the vue-i18n config meant to be inferred from multiple layers? I would imagine configurations like fallbackWarn: false to bubble up, but it seems that a project has to set that configuration itself even if a layer it uses set it already.
I looked at the source code a bit and it seems to me that only messages are collected from the multiple vue-i18n configs? Is that right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants