Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn only when vueI18n property is set but not found #2468

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

#2464

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #2464

Changed the vueI18n config resolution to only warn when vueI18n has explicitly been set but could not been found. Users seem to confuse the warning with an error or would like to turn it off as they haven't set the property.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Oct 2, 2023
@BobbieGoede BobbieGoede force-pushed the fix/vue-i18n-warning-when-none-specified branch from 3feca8c to 8162e3b Compare October 2, 2023 18:30
@BobbieGoede BobbieGoede force-pushed the fix/vue-i18n-warning-when-none-specified branch from 8162e3b to a0dcc1b Compare October 2, 2023 19:07
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

@kazupon kazupon merged commit 31f06ec into nuxt-modules:next Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warn config file but we don't use it
2 participants