-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove jsTsFormatResource
experimental
#2531
Conversation
β Live Preview ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
For official release, Iβve just been thinking remove jsTsFormatResource
from experimental.
Not add disableWarnings
option, We should remove gurad logic with options.experimental.jsTsFormatResource
Line 64 in 1a3cc5c
if (options.experimental.jsTsFormatResource) { |
Line 129 in 1a3cc5c
if (i18nConfig.experimental?.jsTsFormatResource) { |
I completely removed it. You can check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed just now.
please check it!
- `jsTsFormatResource` (default: `false`) - Allow the format `js` and `ts` for locale messages in lazy load translation. | ||
|
||
- `disableWarnings` (default: `false`) - Allow the disable experimental warning messages. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you keep experimental
? π
I'll plan to add server-side i18n @intlify/h3
in near the future. I am working on it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
thank you! β€οΈ
jsTsFormatResource
experimental
* feat: support disableWarning option for experimental * fix: remove jsTsFormatResource from experimental
π Linked issue
#2530
β Type of change
π Description
Support
disableWarnings
option for disable warning messages from experimental features. Resolve #2530π Checklist