Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove jsTsFormatResource experimental #2531

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

GaborTorma
Copy link
Contributor

@GaborTorma GaborTorma commented Nov 1, 2023

πŸ”— Linked issue

#2530

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Support disableWarnings option for disable warning messages from experimental features. Resolve #2530

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

nuxt-studio bot commented Nov 1, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
i18n Edit on Studio β†—οΈŽ View Live Preview aa3cc9d

Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

For official release, I’ve just been thinking remove jsTsFormatResource from experimental.

Not add disableWarnings option, We should remove gurad logic with options.experimental.jsTsFormatResource

if (options.experimental.jsTsFormatResource) {

if (i18nConfig.experimental?.jsTsFormatResource) {

@GaborTorma
Copy link
Contributor Author

GaborTorma commented Nov 2, 2023

I completely removed it. You can check it.

Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed just now.
please check it!

- `jsTsFormatResource` (default: `false`) - Allow the format `js` and `ts` for locale messages in lazy load translation.

- `disableWarnings` (default: `false`) - Allow the disable experimental warning messages.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep experimental? πŸ™
I'll plan to add server-side i18n @intlify/h3 in near the future. I am working on it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!
thank you! ❀️

@kazupon kazupon changed the title feat: support disableWarning option for experimental feat: remove jsTsFormatResource experimental Nov 3, 2023
@kazupon kazupon merged commit 727dba2 into nuxt-modules:main Nov 3, 2023
15 checks passed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
* feat: support disableWarning option for experimental

* fix: remove jsTsFormatResource from experimental
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable option for experimental warnings
2 participants