Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot translation yaml / json5 resources on server-side #2613

Merged
merged 7 commits into from Dec 12, 2023
Merged

fix: cannot translation yaml / json5 resources on server-side #2613

merged 7 commits into from Dec 12, 2023

Conversation

kazupon
Copy link
Collaborator

@kazupon kazupon commented Dec 12, 2023

🔗 Linked issue

resolve #2606

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede
Copy link
Collaborator

Nice! It looks like the yaml files are loaded correctly.

I see you added json5 files as well, these are not working/translating on the server-side for me, should that work in this PR too or would that be a separate PR?

@kazupon kazupon changed the title fix: cannot translation yaml resources on server-side fix: cannot translation yaml / json5 resources on server-side Dec 12, 2023
@kazupon
Copy link
Collaborator Author

kazupon commented Dec 12, 2023

@BobbieGoede
Thank you for your quick review!
I've just fixed your review points and tests.

@BobbieGoede
Copy link
Collaborator

All working well now! 💪

@BobbieGoede BobbieGoede merged commit 4bf4f50 into main Dec 12, 2023
7 checks passed
@BobbieGoede BobbieGoede deleted the fix/2606 branch December 12, 2023 09:31
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@kazupon @BobbieGoede
fix: cannot translation yaml / json5 resources on server-side (nuxt-m…
b8684bc 
…odules#2613)

Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobbieGoede BobbieGoede Awaiting requested review from BobbieGoede

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server-side translations don't work with yaml files
2 participants
@kazupon @BobbieGoede