Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in link of "Edit this page on GitHub" #2699

Merged
merged 1 commit into from Jan 15, 2024

Conversation

PabloLION
Copy link
Contributor

@PabloLION PabloLION commented Jan 15, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Update app.config.ts so the link "Edit this page on GitHub" on every page would work correctly

The old link "Edit this page on GitHub" was targeting https://github.com/nuxt-modules/nuxt-modules/i18n/ due to the owner: "nuxt-modules" was repeated also in the repo indocus.github in app.config.ts. This made the hyperlink redirects the user to a wrong URL.

AFAIK, there's no open issue (I did a quick search)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!
thanks!

@kazupon kazupon merged commit 89e3d51 into nuxt-modules:main Jan 15, 2024
3 checks passed
@PabloLION
Copy link
Contributor Author

very quick response! thanks ❀️

DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants