Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: route param parsing #2711

Merged
merged 4 commits into from Jan 19, 2024
Merged

fix: route param parsing #2711

merged 4 commits into from Jan 19, 2024

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #1910

This PR syncs the route segment parsing logic with that of Nuxt.

I haven't added regression tests.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Jan 18, 2024
kazupon
kazupon reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially, I think parseSegument should be exported via nuxt/kit. /cc @danielroe

@BobbieGoede
Copy link
Collaborator Author

I agree that would be a better long term solution, I opened an issue to track that some time ago (nuxt/nuxt#23521). Until it's exported I think we should keep our copy of the utilities up to date so we don't break any projects.

@kazupon
Copy link
Collaborator

kazupon commented Jan 19, 2024

Until it's exported I think we should keep our copy of the utilities up to date so we don't break any projects.

Yes, it is. That makes sense. I’ll merge this PR! 😉

@kazupon kazupon merged commit ba90b1f into nuxt-modules:main Jan 19, 2024
7 checks passed
@BobbieGoede BobbieGoede mentioned this pull request Mar 14, 2024
Closed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@BobbieGoede
fix: route param parsing (nuxt-modules#2711)
8ccecb8 
* fix: route param parsing

* test: update snapshots and tests

* test: fix test custom route

* test: fix fixture localePath usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees

@BobbieGoede BobbieGoede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional route params get merged into one
2 participants
@BobbieGoede @kazupon