feat: locales generated type narrowing
#2722
Merged
+262
−397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
approved these changes
Jan 22, 2024
kazupon
changed the title
locales generated type narrowinglocales generated type narrowing
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
* refactor: options passing * feat: narrow `locales` based on generated options * chore: remove type assertions in playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR is built on top of #2714, I have it marked WIP/draft until that PR has been merged/reviewed.
Resolves #2628
Now that
vue-i18n-routinghas been fully integrated we have more control over the types, this PR changes the augmentedvue-i18ntypes based on the generated options of a project. This way thelocalestype will be correctly inferred based on whether it was configured asstring[]orLocaleObject[]in the configuration file (or that of extended layers).📝 Checklist