Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setLocale throws error updating locale cookie from plugin #2783

Merged
merged 3 commits into from Feb 13, 2024

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Feb 13, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This should be a more complete fix for #2554 (comment), looks like the main issue was the useCookie usage, which this PR moves out of the function and passes the CookieRef to the utility/internal functions instead.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Feb 13, 2024
@BobbieGoede BobbieGoede marked this pull request as draft February 13, 2024 13:31
@BobbieGoede BobbieGoede marked this pull request as ready for review February 13, 2024 13:33
@BobbieGoede BobbieGoede removed the request for review from kazupon February 13, 2024 14:20
@BobbieGoede BobbieGoede changed the title fix: setLocale throwing error when updating locale cookie from plugin fix: setLocale throws error updating locale cookie from plugin Feb 13, 2024
@BobbieGoede BobbieGoede merged commit 61d5428 into nuxt-modules:main Feb 13, 2024
4 checks passed
@BobbieGoede BobbieGoede deleted the fix/set-locale-from-plugin branch February 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant