Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: runtime config support for detectBrowserLanguage #2824

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

These have been merged and released

Primary motivation for adding runtime support is to actually to merge more test files πŸ˜‚. Most if not all code for detectBrowserLanguage is used at runtime, so there is no need to rebuild the project to test each options.

unjs/nitro#1831 allows us to override runtime configs objects with environment variables, as this is currently not possible.

This PR changes the @nuxt/test-utils code further, startServer now optionally accepts additional environment variables. And I added helper functions to make setting runtime config variables via environment variables easier.

Using the following in a test

  await setRuntimeConfig({
    public: {
      i18n: {
        detectBrowserLanguage: false
      }
    }
  })

Will be converted into NUXT_PUBLIC_I18N_DETECT_BROWSER_LANGUAGE=false and restarts the server with all properties in the passed object.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede changed the title feat: runtime config detect browser language feat: runtime config detectBrowserLanguage Mar 1, 2024
@BobbieGoede BobbieGoede changed the title feat: runtime config detectBrowserLanguage feat: runtime config support for detectBrowserLanguage Mar 1, 2024
@BobbieGoede BobbieGoede self-assigned this Mar 1, 2024
@BobbieGoede BobbieGoede requested a review from kazupon March 1, 2024 12:50
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! πŸ‘
LGTM for your PR!

You need to resolve the conflicts!

@BobbieGoede BobbieGoede force-pushed the feature/runtime-config-detect-browser-language-4 branch from ef097a2 to 8283c8c Compare March 2, 2024 08:56
@kazupon kazupon merged commit b6edab3 into nuxt-modules:main Mar 2, 2024
7 checks passed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
…s#2824)

* feat: add runtime config support for detectBrowserLanguage

* chore(deps): update dependencies

* test: add test helper to set runtime config

* test: merge browser language detection tests

* test: merge baseUrl tests

* chore(deps): update dependencies

* refactor: cleanup

* chore(deps): update dependencies

* chore(deps): update dependencies

* fix: add type exceptions

* chore(deps): update dependencies

* fix: composable usage and passing

* chore(deps): update nuxt dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants