Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: common composable options not being passed to getRouteBaseName #2865

Merged
merged 4 commits into from Mar 20, 2024
Merged

fix: common composable options not being passed to getRouteBaseName #2865

merged 4 commits into from Mar 20, 2024

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2864

Adds regression tests for Nuxt context extensions

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Mar 20, 2024
@BobbieGoede BobbieGoede force-pushed the fix/get-route-base-name-nuxt-extension branch 2 times, most recently from 1cda6be to 40217aa Compare March 20, 2024 21:38
@BobbieGoede BobbieGoede force-pushed the fix/get-route-base-name-nuxt-extension branch from 40217aa to 2c1db50 Compare March 20, 2024 21:49
@BobbieGoede BobbieGoede merged commit 946ca63 into nuxt-modules:main Mar 20, 2024
7 checks passed
@BobbieGoede BobbieGoede mentioned this pull request Apr 2, 2024
Closed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@BobbieGoede
fix: common composable options not being passed to getRouteBaseName (…
f8e9708 
…nuxt-modules#2865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BobbieGoede BobbieGoede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$getRouteBaseName CommonComposableOptions error WTF
1 participant
@BobbieGoede