fix: options passed with installModule
are overwritten
#2882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
installModule
Β #2809β Type of change
π Description
Resolves #2874
Resolves #2809
As options passed to the module
setup
already contain the merged layer options, the only way we can retrieve thelocales
andvueI18n
options are by looking for absolute paths and whether they do not match layer configurations.And since we can't know which module installs our module, and we also don't know which layer has the installer module configured, we don't know the priority at which we should merge these options. So far it seems that the approach in other modules is to treat
installModule
as having a higher priority than the project layer.I added support for this since it seems there is demand for this functionality, but I honestly think this will cause issues if a lot of modules end up doing this, extending projects with layers is a much more predictable and safe approach and as such I have recommended this in the documentation as well.
π Checklist