feature: match against full language code provided by the browser #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 3 3
Lines 122 122
Branches 32 32
=======================================
Hits 121 121
Misses 1 1Continue to review full report at Codecov.
|
Closed
|
Looks fine. Can you please go ahead with this PR before long? Thank you! |
For detecting and redirecting to browser language the module only looked at first two letters of the first language of the language codes provided by the browser so it wasn't able to match up more specific locale codes like en-GB or zh-CN and didn't consider lower-ranked language codes that user preferred. Fix by matching checking against full language code first and then falling back to only first two letters if no higher-ranked code was found. And consider all user-preferred locales. Resolves #650 Resolves #563
|
Thank you! |
rchl
added a commit
that referenced
this pull request
Apr 3, 2020
Related to PR #651 and new browser language detection logic that takes into account full (like en-GB) language codes. Co-authored-by: mcdmaster <mcdmaster@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detecting and redirecting to browser language the module only
looked at first two letters of the language codes provided by the
browser so it wasn't able to match up more specific locale codes like
en-GB or zh-CN.
Fix by matching checking against full language code first and then
falling back to only first two letters if no higher-ranked code
was found.
Resolves #650
Resolves #563